From 0420088fbfc24231abf5a69c232c73e7754016f5 Mon Sep 17 00:00:00 2001 From: Josh Lay Date: Sat, 14 Oct 2023 22:49:55 -0500 Subject: [PATCH 1/5] add requirements for linting --- .github/workflows/pylint.yml | 7 ++++--- requirements.txt | 4 ++++ 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 requirements.txt diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml index 383e65c..5ebdd1b 100644 --- a/.github/workflows/pylint.yml +++ b/.github/workflows/pylint.yml @@ -7,7 +7,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: ["3.8", "3.9", "3.10"] + python-version: ["3.8", "3.9", "3.10", "3.11"] steps: - uses: actions/checkout@v3 - name: Set up Python ${{ matrix.python-version }} @@ -16,8 +16,9 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install dependencies run: | - python -m pip install --upgrade pip - pip install pylint + python3 -m pip install --upgrade pip + pip3 install -r requirements.txt + pip3 install pylint - name: Analysing the code with pylint run: | pylint $(git ls-files '*.py') diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 0000000..5d5cd85 --- /dev/null +++ b/requirements.txt @@ -0,0 +1,4 @@ +i3ipc +xdg +systemd-python +PyYAML From 1e431b77a54fb3089091e4eb5ea0aa9c30907b08 Mon Sep 17 00:00:00 2001 From: Josh Lay Date: Sat, 14 Oct 2023 22:58:35 -0500 Subject: [PATCH 2/5] requirement: libsystemd-dev --- .github/workflows/pylint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml index 5ebdd1b..604d4a5 100644 --- a/.github/workflows/pylint.yml +++ b/.github/workflows/pylint.yml @@ -19,6 +19,7 @@ jobs: python3 -m pip install --upgrade pip pip3 install -r requirements.txt pip3 install pylint + apt install -y libsystemd-dev - name: Analysing the code with pylint run: | pylint $(git ls-files '*.py') From 74b585b046a8feffd4d44c7258a55c52605ae034 Mon Sep 17 00:00:00 2001 From: Josh Lay Date: Sat, 14 Oct 2023 22:59:26 -0500 Subject: [PATCH 3/5] requirement: fix libsystemd-dev placement --- .github/workflows/pylint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml index 604d4a5..ff07e99 100644 --- a/.github/workflows/pylint.yml +++ b/.github/workflows/pylint.yml @@ -16,10 +16,10 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install dependencies run: | + apt install -y libsystemd-dev python3 -m pip install --upgrade pip pip3 install -r requirements.txt pip3 install pylint - apt install -y libsystemd-dev - name: Analysing the code with pylint run: | pylint $(git ls-files '*.py') From 1560ba722caa657cc829f882e04a723dc85ac30d Mon Sep 17 00:00:00 2001 From: Josh Lay Date: Sat, 14 Oct 2023 23:01:09 -0500 Subject: [PATCH 4/5] requirement: try sudo apt --- .github/workflows/pylint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml index ff07e99..8be26b6 100644 --- a/.github/workflows/pylint.yml +++ b/.github/workflows/pylint.yml @@ -16,7 +16,7 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install dependencies run: | - apt install -y libsystemd-dev + sudo apt install -y libsystemd-dev python3 -m pip install --upgrade pip pip3 install -r requirements.txt pip3 install pylint From 6e6089c2df422b870c5b6f6e9d640c8ddda07b5a Mon Sep 17 00:00:00 2001 From: Josh Lay Date: Sat, 14 Oct 2023 23:04:24 -0500 Subject: [PATCH 5/5] pylint: ignore line-too-long --- startup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/startup.py b/startup.py index 75205fe..ec92586 100755 --- a/startup.py +++ b/startup.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# pylint: disable=line-too-long """ A smart but also lazy login autostart manager for i3/Sway.