From 23f0ad541df18ab0c509fb59df9cfb4d2bfb2a37 Mon Sep 17 00:00:00 2001
From: Josh Lay <me@jlay.io>
Date: Sat, 26 Nov 2022 22:59:35 -0600
Subject: [PATCH] linting clean up

---
 host_vars/localhost.yml |  4 ++--
 playbook.yml            | 43 +++++++++++++++++++++--------------------
 2 files changed, 24 insertions(+), 23 deletions(-)

diff --git a/host_vars/localhost.yml b/host_vars/localhost.yml
index 2b88e84..d354ee1 100644
--- a/host_vars/localhost.yml
+++ b/host_vars/localhost.yml
@@ -4,7 +4,7 @@
 # adds a power multiplier, see comments below for more info
 # more reference driver profiles may be added, but do not remove default.
 amdgpu_profiles:
-  default:    
+  default:
     pwrmode: 0
     pwr_cap_multi: 0.789473684210526 # 255W - default
   3D:
@@ -46,4 +46,4 @@ gpu_clock_max: "2500" # default 2529
 gpumem_clock_max: "1050"
 #
 # optional, applies offset to GPU voltage, eg: '+100' = to boost GPU core voltage 100mV or 0.1V. for the 'custom' GPU profile.
-#gpu_mv_offset: "+50"
+# gpu_mv_offset: "+50"
diff --git a/playbook.yml b/playbook.yml
index 4a5a82d..1935642 100644
--- a/playbook.yml
+++ b/playbook.yml
@@ -1,5 +1,6 @@
 ---
 - hosts: localhost
+  name: "Configure 'tuned' with AMD GPU control"
   become: true
   vars:
     # list of source tuned profiles available on Fedora (TODO: should dynamically discover)
@@ -13,7 +14,7 @@
       - powersave
       - virtual-host
   handlers:
-    - name: restart tuned
+    - name: Restart tuned
       ansible.builtin.service:
         name: tuned
         state: restarted
@@ -21,8 +22,8 @@
     - name: Gather package facts
       ansible.builtin.package_facts:
         manager: auto
-    - name: replace 'power-profiles-daemon' with 'tuned' on Fedora 35+
-      dnf: # use with_items since 'dnf' module in Ansible doesn't support 'swap'
+    - name: Replace 'power-profiles-daemon' with 'tuned' on Fedora 35+
+      ansible.builtin.package: # use with_items/pkg since 'dnf' module in Ansible doesn't support 'swap'
         name: "{{ item.name }}"
         state: "{{ item.state }}"
       with_items:
@@ -35,19 +36,19 @@
       register: fed_ppdtuned_swap
       # 'power-profiles-daemon' was added/conflicts with 'tuned' since F35
       # otherwise, ensure the 'tuned' package is installed
-    - name: install tuned
-      package:
+    - name: Install tuned
+      ansible.builtin.package:
         name: tuned
         state: present
       when: (fed_ppdtuned_swap is not defined) or ('tuned' not in ansible_facts.packages)
-    - name: determine GPU device in drm subsystem
-      shell:
+    - name: Determine GPU device in drm subsystem
+      ansible.builtin.shell:
         cmd: grep -ls ^connected /sys/class/drm/*/status | grep -o card[0-9] | sort | uniq | sort -h | tail -1
         executable: /bin/bash
       changed_when: false
       register: card
-    - name: find hwmon/max power capability file for {{ card.stdout }}
-      find:
+    - name: Find hwmon/max power capability file for {{ card.stdout }}
+      ansible.builtin.find:
         paths: /sys/class/drm/{{ card.stdout }}/device/hwmon
         file_type: file
         recurse: true
@@ -55,8 +56,8 @@
         patterns:
           - '^power1_cap_max$'
       register: hwmon
-    - name: find hwmon/current power limit file for {{ card.stdout }}
-      find:
+    - name: Find hwmon/current power limit file for {{ card.stdout }}
+      ansible.builtin.find:
         paths: /sys/class/drm/{{ card.stdout }}/device/hwmon
         file_type: file
         recurse: true
@@ -64,20 +65,20 @@
         patterns:
           - '^power1_cap$'
       register: powercap_set
-    - name: get max power capability for {{ card.stdout }}
-      slurp:
+    - name: Get max power capability for {{ card.stdout }}
+      ansible.builtin.slurp:
         src: "{{ hwmon.files.0.path }}"
       register: power_max_b64
-    - name: create custom profile directories
-      file:
+    - name: Create custom profile directories
+      ansible.builtin.file:
         state: directory
         path: /etc/tuned/{{ item.1 }}-amdgpu-{{ item.0.key }}
         mode: "0755"
       with_nested:
         - "{{ lookup('dict', amdgpu_profiles) }}"
         - "{{ base_profiles }}"
-    - name: template AMDGPU control/reset scripts
-      template:
+    - name: Template AMDGPU control/reset scripts
+      ansible.builtin.template:
         src: templates/amdgpu-clock.sh.j2
         dest: /etc/tuned/{{ item.1 }}-amdgpu-{{ item.0.key }}/amdgpu-clock.sh
         owner: root
@@ -87,8 +88,8 @@
         - "{{ lookup('dict', amdgpu_profiles) }}"
         - "{{ base_profiles }}"
       notify: restart tuned
-    - name: template custom tuned profiles
-      template:
+    - name: Template custom tuned profiles
+      ansible.builtin.template:
         src: templates/tuned.conf.j2
         dest: /etc/tuned/{{ item.1 }}-amdgpu-{{ item.0.key }}/tuned.conf
         owner: root
@@ -98,7 +99,7 @@
         - "{{ lookup('dict', amdgpu_profiles) }}"
         - "{{ base_profiles }}"
       notify: restart tuned
-    - name: ensure tuned is enabled
-      service:
+    - name: Ensure tuned is enabled
+      ansible.builtin.service:
         name: tuned
         enabled: true